feat(boto3): Add response, retry, and error span attributes by pabloDeputter · Pull Request #7499 · getsentry/sentry-python

pabloDeputter · 2026-09-14T12:53:34Z

Description

Add generic response, retry, and error attribute enrichment to boto3 spans. Previously, only recorded request and client metadata was instrumented; information after the call such as HTTP status, retry count, etc was omitted. The new attributes follow the OTel AWS SDK conventions.

Changes

add SPANDATA consts: AWS_REQUEST_ID, AWS_EXTENDED_REQUEST_ID, HTTP_REQUEST_RESEND_COUNT, and ERROR_TYPE.
add _get_response_attributes() to extract http.response_status_code, http.request_resend_count, aws.request_id, and aws.extended_request_id.
Add erorr.type from ClientError.Eror.Code or the exception class, without recording error messages.

Issues

Resolves #7476

github-actions · 2026-09-14T13:05:08Z

Codecov Results 📊

✅ 132851 passed | ⏭️ 7220 skipped | Total: 140071 | Pass Rate: 94.85% | Execution Time: 452m 40s

📊 Comparison with Base Branch

Metric	Change
Total Tests	📈 +3487
Passed Tests	📈 +3524
Failed Tests	📉 -60
Skipped Tests	📈 +23

➖ Removed Tests (60)

View removed tests

test_input_attributes_nonstreaming_chat[False-True-False-messages1-expected_system_instructions1-expected_input_messages1]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat[False-True-False-messages2-expected_system_instructions2-expected_input_messages2]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat[False-True-False-messages3-expected_system_instructions3-expected_input_messages3]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat[False-False-True-messages0-expected_system_instructions0-expected_input_messages0]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat[False-False-True-messages1-expected_system_instructions1-expected_input_messages1]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat[False-False-True-messages2-expected_system_instructions2-expected_input_messages2]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat[False-False-True-messages3-expected_system_instructions3-expected_input_messages3]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat[False-False-False-messages0-expected_system_instructions0-expected_input_messages0]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat[False-False-False-messages1-expected_system_instructions1-expected_input_messages1]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat[False-False-False-messages2-expected_system_instructions2-expected_input_messages2]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat[False-False-False-messages3-expected_system_instructions3-expected_input_messages3]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat_async[True-True-True-messages0-expected_system_instructions0-expected_input_messages0]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat_async[True-True-True-messages1-expected_system_instructions1-expected_input_messages1]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat_async[True-True-True-messages2-expected_system_instructions2-expected_input_messages2]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat_async[True-True-True-messages3-expected_system_instructions3-expected_input_messages3]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat_async[True-True-False-messages0-expected_system_instructions0-expected_input_messages0]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat_async[True-True-False-messages1-expected_system_instructions1-expected_input_messages1]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat_async[True-True-False-messages2-expected_system_instructions2-expected_input_messages2]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat_async[True-True-False-messages3-expected_system_instructions3-expected_input_messages3]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat_async[True-False-True-messages0-expected_system_instructions0-expected_input_messages0]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat_async[True-False-True-messages1-expected_system_instructions1-expected_input_messages1]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat_async[True-False-True-messages2-expected_system_instructions2-expected_input_messages2]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat_async[True-False-True-messages3-expected_system_instructions3-expected_input_messages3]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat_async[True-False-False-messages0-expected_system_instructions0-expected_input_messages0]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat_async[True-False-False-messages1-expected_system_instructions1-expected_input_messages1]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat_async[True-False-False-messages2-expected_system_instructions2-expected_input_messages2]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat_async[True-False-False-messages3-expected_system_instructions3-expected_input_messages3]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat_async[False-True-True-messages0-expected_system_instructions0-expected_input_messages0]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat_async[False-True-True-messages1-expected_system_instructions1-expected_input_messages1]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat_async[False-True-True-messages2-expected_system_instructions2-expected_input_messages2]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat_async[False-True-True-messages3-expected_system_instructions3-expected_input_messages3]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat_async[False-True-False-messages0-expected_system_instructions0-expected_input_messages0]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat_async[False-True-False-messages1-expected_system_instructions1-expected_input_messages1]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat_async[False-True-False-messages2-expected_system_instructions2-expected_input_messages2]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat_async[False-True-False-messages3-expected_system_instructions3-expected_input_messages3]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat_async[False-False-True-messages0-expected_system_instructions0-expected_input_messages0]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat_async[False-False-True-messages1-expected_system_instructions1-expected_input_messages1]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat_async[False-False-True-messages2-expected_system_instructions2-expected_input_messages2]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat_async[False-False-True-messages3-expected_system_instructions3-expected_input_messages3]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat_async[False-False-False-messages0-expected_system_instructions0-expected_input_messages0]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat_async[False-False-False-messages1-expected_system_instructions1-expected_input_messages1]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat_async[False-False-False-messages2-expected_system_instructions2-expected_input_messages2]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat_async[False-False-False-messages3-expected_system_instructions3-expected_input_messages3]
- File: tests.integrations.mistral.test_mistral
test_output_attributes_nonstreaming_chat[True-True-True]
- File: tests.integrations.mistral.test_mistral
test_output_attributes_nonstreaming_chat[True-True-False]
- File: tests.integrations.mistral.test_mistral
test_output_attributes_nonstreaming_chat[True-False-True]
- File: tests.integrations.mistral.test_mistral
test_output_attributes_nonstreaming_chat[True-False-False]
- File: tests.integrations.mistral.test_mistral
test_output_attributes_nonstreaming_chat[False-True-True]
- File: tests.integrations.mistral.test_mistral
test_output_attributes_nonstreaming_chat[False-True-False]
- File: tests.integrations.mistral.test_mistral
test_output_attributes_nonstreaming_chat[False-False-True]
- File: tests.integrations.mistral.test_mistral
test_output_attributes_nonstreaming_chat[False-False-False]
- File: tests.integrations.mistral.test_mistral
test_output_attributes_nonstreaming_chat_async[True-True-True]
- File: tests.integrations.mistral.test_mistral
test_output_attributes_nonstreaming_chat_async[True-True-False]
- File: tests.integrations.mistral.test_mistral
test_output_attributes_nonstreaming_chat_async[True-False-True]
- File: tests.integrations.mistral.test_mistral
test_output_attributes_nonstreaming_chat_async[True-False-False]
- File: tests.integrations.mistral.test_mistral
test_output_attributes_nonstreaming_chat_async[False-True-True]
- File: tests.integrations.mistral.test_mistral
test_output_attributes_nonstreaming_chat_async[False-True-False]
- File: tests.integrations.mistral.test_mistral
test_output_attributes_nonstreaming_chat_async[False-False-True]
- File: tests.integrations.mistral.test_mistral
test_output_attributes_nonstreaming_chat_async[False-False-False]
- File: tests.integrations.mistral.test_mistral
test_cache_spans_templatetag[True]
- File: tests.integrations.django.test_cache_module

All tests are passing successfully.

✅ Patch coverage is 100.00%. Project has 2562 uncovered lines.
✅ Project coverage is 90.34%. Comparing base (6868ffd) to head (064eab6).

Files with missing lines (1)

File	Patch %	Lines
sentry_sdk/integrations/boto3/_instrumentation.py	100.00%	⚠️ 1 partials

Coverage diff

@@            Coverage Diff             @@
##        master       #PR       +/-##
==========================================
+ Coverage    90.30%    90.34%    +0.04%
==========================================
  Files          195       199        +4
  Lines        26261     26524      +263
  Branches      9798      9864       +66
==========================================
+ Hits         23714     23962      +248
- Misses        2547      2562       +15
- Partials      1485      1495       +10

Generated by Codecov Action

cursor

Stale Bugbot comment from a previous run.

pabloDeputter added this pull request to stack #7500 September 14, 2026 12:53

pabloDeputter changed the title ~~Pablo/add boto3 response retry error attributes~~ feat(boto3): Add response, retry, and error span attributes Sep 14, 2026

pabloDeputter force-pushed the pablo/add-boto3-response-retry-error-attributes branch from a15c641 to 56a7ab6 Compare September 14, 2026 14:42

pabloDeputter force-pushed the pablo/add-boto3-response-retry-error-attributes branch from 56a7ab6 to 176096b Compare September 15, 2026 12:58

sentry-warden Bot reviewed Sep 15, 2026

View reviewed changes

Comment thread tests/integrations/boto3/test_client.py

pabloDeputter force-pushed the pablo/add-boto3-response-retry-error-attributes branch from af6b9a8 to 49474d0 Compare September 17, 2026 15:48

pabloDeputter force-pushed the pablo/add-boto3-response-retry-error-attributes branch 2 times, most recently from 2e63bac to 35f0dc3 Compare September 17, 2026 16:00

pabloDeputter marked this pull request as ready for review September 17, 2026 16:07

pabloDeputter requested a review from a team as a code owner September 17, 2026 16:07

pabloDeputter force-pushed the pablo/add-boto3-response-retry-error-attributes branch from 76e7425 to f922864 Compare September 18, 2026 13:02

cursor Bot reviewed Sep 18, 2026

View reviewed changes

Comment thread sentry_sdk/integrations/boto3/_client.py Outdated

pabloDeputter removed this pull request from stack #7500 September 18, 2026 14:34

pabloDeputter added this pull request to stack #7539 September 18, 2026 14:35

pabloDeputter force-pushed the pablo/add-boto3-response-retry-error-attributes branch from 4fae1c9 to cdd5c95 Compare September 18, 2026 15:06

pabloDeputter removed this pull request from stack #7539 September 18, 2026 15:08

pabloDeputter added this pull request to stack #7541 September 18, 2026 15:08

pabloDeputter force-pushed the pablo/add-boto3-response-retry-error-attributes branch from cdd5c95 to d55060f Compare September 18, 2026 15:20

pabloDeputter force-pushed the pablo/add-boto3-response-retry-error-attributes branch 3 times, most recently from 6c9e3a8 to a72a791 Compare September 21, 2026 16:07

pabloDeputter added this pull request to stack #7792 September 30, 2026 12:05

pabloDeputter force-pushed the pablo/add-boto3-response-retry-error-attributes branch from 6edfb01 to 850c129 Compare September 30, 2026 13:31

pabloDeputter added 21 commits September 30, 2026 16:04

ref(boto3): simplify client span lifecycle and header handling

d32a43f

feat(boto3): add attributes to consts.py

822438b

merge changes

46d24b2

add tests

30d1e3f

patch correct methods

250699d

lint

d9edef5

use ordered search for request id and hist id

90383dc

ref(boto3): remove redundant span checks during enrichment

d482500

fix duplicates when merging

26fdcb1

use consts and string lookup for client.getintegration

eeac30a

lint

8b61aac

ruff

308eb5f

ref(boto3): add permalinks

8e4ce5a

fix(boto3): add error.type to both span kinds

832d90d

ref(boto3): specify docstring for _set_span_attributes() further

0ee5f14

ref(boto3): use f-string instead

a8f521e

ref(boto3): remove comment regarding HTTP_REQUEST_RESEND_COUNT

2d92b4e

ref(boto3): remove else block

12dd5e6

tests(boto3): remove uncessary testcases

21794bf

ref(boto3): remove uncessary defensive conditionals

7859e97

fix flaky test

1f4e936

pabloDeputter force-pushed the pablo/add-boto3-response-retry-error-attributes branch from 2718630 to 1f4e936 Compare September 30, 2026 14:05

pabloDeputter added 2 commits September 30, 2026 17:11

trigger tests

d5d1faf

trigger tests

064eab6

pabloDeputter merged commit bc11cb7 into master Sep 30, 2026
314 of 316 checks passed

pabloDeputter deleted the pablo/add-boto3-response-retry-error-attributes branch September 30, 2026 15:50

Navigation Menu

Repository navigation

feat(boto3): Add response, retry, and error span attributes - #7499

feat(boto3): Add response, retry, and error span attributes#7499
pabloDeputter merged 23 commits into
pablo/improve-boto3-call-lifecyclefrom
pablo/add-boto3-response-retry-error-attributes

pabloDeputter commented Sep 14, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Sep 14, 2026 •

edited

Loading

Uh oh!

Uh oh!

cursor Bot left a comment •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

pabloDeputter commented Sep 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changes

Issues

Uh oh!

github-actions Bot commented Sep 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Results 📊

📊 Comparison with Base Branch

➖ Removed Tests (60)

Uh oh!

Uh oh!

cursor Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

pabloDeputter commented Sep 14, 2026 •

edited

Loading

github-actions Bot commented Sep 14, 2026 •

edited

Loading

cursor Bot left a comment •

edited

Loading